Fixed unbounded write and check return values of sscanf #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format string "%s" that does not control the length of data written may overflow.
Failing to check that a call to 'scanf' actually writes to an output variable can lead to unexpected behavior at reading time.
szsam
changed the title
Nightwalker-87
approved these changes
Apr 23, 2023
Nightwalker-87
changed the title
gszy
approved these changes
Apr 23, 2023
|
This looks like a security vulnerability. Should there be a CVE associated with this? |
|
@Machiry I'm not sure how relevant this is with respect to the use case of this software. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format string "%s" that does not control the length of data written may overflow.