Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed include path for header file poll.h. #1370

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

ii8
Copy link
Contributor

@ii8 ii8 commented Feb 15, 2024

The correct include path for poll(2) is poll.h not sys/poll.h. sys/poll.h may not be available on some libcs or may issue a warning. In particular this fixes a warning on musl systems.

/usr/include/sys/poll.h:1:2: error: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Werror=cpp]
    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
      |  ^~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [CMakeFiles/st-util.dir/build.make:76: CMakeFiles/st-util.dir/src/st-util/gdb-remote.c.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:342: CMakeFiles/st-util.dir/all] Error 2
make[1]: *** [Makefile:156: all] Error 2
make: *** [Makefile:34: release] Error 2

The correct include path for poll(2) is poll.h not sys/poll.h.
sys/poll.h may not be available on some libcs or may issue a
warning. In particular this fixes a warning on musl systems.
@Nightwalker-87 Nightwalker-87 merged commit 710e1d3 into stlink-org:testing Feb 18, 2024
10 checks passed
@Nightwalker-87 Nightwalker-87 changed the title Fix poll.h include path Fix poll.h include pathFixed include path for header file poll.h. Feb 18, 2024
@Nightwalker-87 Nightwalker-87 changed the title Fix poll.h include pathFixed include path for header file poll.h. Fixed include path for header file poll.h. Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants