Improve ARM semi-hosting support #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the following operations: - SYS_OPEN - SYS_CLOSE - SYS_WRITE - SYS_READ - SYS_ERRNO - SYS_REMOVE - SYS_SEEK The use of utility functions mem_read() and mem_write() add an unnecessary memcpy() call. All buffer transfer could be done directly in the sl->q_buf data instead of using a temporary transfer buffer. However, given the relative slowness of target memory transfer, I don't think that this has a big impact on performances
Closed
Closed
This was
linked to
issues
Mar 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the following operations:
The use of utility functions mem_read() and mem_write() add an
unnecessary memcpy() call. All buffer transfer could be done directly in
the sl->q_buf data instead of using a temporary transfer buffer.
However, given the relative slowness of target memory transfer, I don't
think that this has a big impact on performances