You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have seen problems with travis infrastructure and old tools versions the git/project version gets broken. Now this is more reliable and has always a fallback to the .version file. When the utilities are build the version is linked into the executable and printed on startup like OpenOCD does.
@nekromant could you review this works for you, as I have moved stuff all over the place and maybe have broken debian packaging.
As everybody is fearly busy and some contribution is pending for debian packaging (fixes) we need this merged. I will merge it myself for now, when there are questions feel free to place them here.
@xor-gate Terribly sorry, I'm currently away fishing till Wednesday-Thursday and there's (a. Very poor cellphone coverage b. I have no deb-pkg stuff on my 'field' laptop). I'll check everything once I'm back, hope you're not in a terrible hurry. (And it looks like my homeserver infrastructure along with jenkins is down as well due to a power outage).
Hi @nekromant yeah I just figured out a few days ago. It is no showstopper. I already have merged as someone else is improving the debian packaging. Have fun fishing!
@xor-gate, @OsterlaD I'm finally back. Looks like I've missed all the fun with the recent debian packaging fixes. Anyways, I've tested the current master, debian packaging and did a full ci run, everything looks fine so far.
Regarding the recent deb packaging fixes by OsterlaD that I've missed out:
Do we really need to duplicate all the file installation rules in debian/rules? I suggest we do as much of the installation as possible with CMakeLists.txt, so that debian/rules would do as much as possible automatically.
Is there any rationale for building both debug and release builds of stlink when packaging?
Use of cmake install would be better in terms of maintenance.
I am not sure how to tell cmake where to install
adapt debian/*.install files to copy from cmake install dir, instead of from debian/tmp
or you can manage to install to debain/tmp with cmake
cmake should handle multiarch library paths
Just that tests depends on debug build. The build stage calls make all and all depends on release. The tests stage calls make test and test depends on debug. This is why both where build. I think automated tests where a good thing and should run, but you can disable it by add override_dh_auto_tests: to debian/rules, if you want.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xor-gate
force-pushed
the
cmake-fixes
branch
from
I have seen problems with travis infrastructure and old tools versions the git/project version gets broken. Now this is more reliable and has always a fallback to the
.versionfile. When the utilities are build the version is linked into the executable and printed on startup like OpenOCD does.@nekromant could you review this works for you, as I have moved stuff all over the place and maybe have broken debian packaging.