Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Problems with debian package generation #472

Closed
2 tasks done
OsterlaD opened this issue Sep 18, 2016 · 13 comments · Fixed by #485
Closed
2 tasks done

packaging: Problems with debian package generation #472

OsterlaD opened this issue Sep 18, 2016 · 13 comments · Fixed by #485

Comments

@OsterlaD
Copy link
Contributor

  • Operating system: Linux
  • git commit hash: 1.2.0-118-g7023a9a
  • debuild failed with "can not find install files" message
  • man pages not installed
@xor-gate
Copy link
Member

xor-gate commented Sep 18, 2016

Could you try the cmake-fixes branch? Probably this needs some work because I'm developing currently from a mac. Probably I have broken the debian packaging. Could you give more details how you package stlink?

See PR #469

@xor-gate xor-gate added this to the v1.3.0 milestone Sep 18, 2016
@OsterlaD
Copy link
Contributor Author

OsterlaD commented Sep 18, 2016

I will have a look at this branch.
Can you have a look on pull request #473.
These are my changes to fix broken install and some warnings.

@xor-gate
Copy link
Member

Looks good, I only see no reason the have a duplicate copyright file into the debian folder. Is there no way to use the LICENSE file and copy it over in generation to debian folder? As mentioned in the pull request you should rely only for man pages on doc/man/*.1 and not the build/Debug folder. If you fix this I will merge.

@OsterlaD
Copy link
Contributor Author

A good point,
two possible solutions:

  • a symbolic link, maybe not the best solution, but simple
  • copy it at build time, I have to figure out when and how

No problem, I will remove build/Debug prefix in manpages file.

Shall I rebase patch stack on cmake-fixes?

@xor-gate
Copy link
Member

You may rebase on cmake-fixes but it will also apply on master because you only changed stuff in the debian folder. The copyright file should be formatted as follows (and not include the LICENSE file from the project)

https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

@OsterlaD
Copy link
Contributor Author

Is doc/man/st-util.1 from "fabien.lementec I fix: add missing st-util.1 until proper solution" really the better than they from build/Debug/doc/man/st-*.1?

@OsterlaD
Copy link
Contributor Author

W: stlink-tools: manpage-has-bad-whatis-entry usr/share/man/man1/st-util.1.gz
W: stlink-tools: manpage-has-errors-from-man usr/share/man/man1/st-util.1.gz 1: warning: macro `PP' not defined
W: stlink-tools: binary-without-manpage usr/bin/st-flash
W: stlink-tools: binary-without-manpage usr/bin/st-info

@OsterlaD
Copy link
Contributor Author

You are right about copyright.
Thanks for this hint.

@OsterlaD
Copy link
Contributor Author

Reworked patch stack on master.
Now manpages contains doc/man/st-.1 entry, corresponding to install entry usr/bin/st-.
The debian/copyright file indicates BSD-3-clause license with copyright holders from LICENSE file.

@OsterlaD
Copy link
Contributor Author

Encountered a problem with rename of lib.

@OsterlaD
Copy link
Contributor Author

Removed this patch from pull request.
Seems it have affects on cmake build.
It requires more then just rename.
This is not very important.

@xor-gate
Copy link
Member

Thank you for your contribution!

@Nightwalker-87 Nightwalker-87 modified the milestones: v1.3.0, v1.6.1 Mar 17, 2020
@Nightwalker-87 Nightwalker-87 changed the title Problems with debian package generation packaging: Problems with debian package generation Mar 17, 2020
@Nightwalker-87 Nightwalker-87 removed this from the v1.6.1 milestone Mar 17, 2020
@Nightwalker-87
Copy link
Member

Finally closed by #485.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants