Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-482 #484

Closed
wants to merge 2 commits into from
Closed

fix-482 #484

wants to merge 2 commits into from

Conversation

OsterlaD
Copy link
Contributor

Implement install delegate and use it in debian/rules.

Install of udev rules and modprobe config is still done in debian/rules.

@xor-gate
Copy link
Member

The top level makefile should have for the install_* targets a dependency to debug/release:
When people directly type make install_debug it will fail. Also we should wrap a install target to install_release.

install_release: release 
...
install_debug: debug
...

@nekromant
Copy link
Contributor

nekromant commented Sep 23, 2016

@xor-gate: It looks addition of the top-level Makefile breaks automated detection of the buildsystem by debhelper, I've fixed that. Please don't yet merge @OsterlaD's fix, I have a cleaner solution on the way.

EDIT: Done, See #485

@OsterlaD
Copy link
Contributor Author

Removed debian fixes.
But install delegate and documentation adaption may apply anyway.

@xor-gate
Copy link
Member

So this can be closed in favor of PR #485 ?

@OsterlaD
Copy link
Contributor Author

I think the install delegates would be useful anyway.
If you do not need them, just close the pull request.

Hopefully he gets its changes stable, it would be a clean solution.

@xor-gate
Copy link
Member

xor-gate commented Sep 25, 2016

I will close this, as soon as the stuff from @nekromant has been fixed/merged. I will add install delegates to the top level makefile. Thank you for you contribution! Feel free to comment on PR #485 if we need to add something.

@xor-gate xor-gate closed this Sep 25, 2016
@stlink-org stlink-org locked and limited conversation to collaborators Sep 25, 2016
@stlink-org stlink-org unlocked this conversation Mar 16, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.3.0 milestone Mar 17, 2020
@Nightwalker-87 Nightwalker-87 linked an issue Mar 17, 2020 that may be closed by this pull request
@Nightwalker-87 Nightwalker-87 linked an issue Mar 17, 2020 that may be closed by this pull request
@Nightwalker-87
Copy link
Member

Closed in favour of #485.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging: Debian packaging progress packaging: Debian packaging is broken yet again
4 participants