Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: Build debian package with more use of cmake #491

Closed
wants to merge 6 commits into from
Closed

packaging: Build debian package with more use of cmake #491

wants to merge 6 commits into from

Conversation

OsterlaD
Copy link
Contributor

@OsterlaD OsterlaD commented Oct 4, 2016

  • Make use of dh --buildsystem cmake, as suggested by nekromant.
  • Keep install rules of module config and udev rules separate, to keep normal cmake install as documented.
  • Move libstlink.so symlink to dev-package, provided by nekromant.

OsterlaD and others added 6 commits September 22, 2016 20:31
@OsterlaD
doc: Remove not required command line.
651b4ea
@OsterlaD
build: Install delegates.
aa5cc2a
@OsterlaD
deb: Use make install.
c2e8254 
Keep udev rules and modprobe config install rules.
@OsterlaD
deb: Adapt usr/share install pattern to install man pages not twice.
60776f4
@OsterlaD
deb: Force dh to use cmake build system.
1bc61ea 
The top-level makefile that was used to drive cmake broke the autodetection
of the used buildsystem by debhelper.

Suggested-by: Andrew Andrianov <andrew@ncrmnt.org>
@nekromant @OsterlaD
debian: Include .so symlink only in -dev package
a3777ac 
This fixes a lintian error

Signed-off-by: Andrew Andrianov <andrew@ncrmnt.org>
Tested-by: Denis Osterland <Denis.Osterland@diehl.com>
@xor-gate
Copy link
Member

xor-gate commented Oct 4, 2016 •
edited

Will this replace the work of PR #485?

@OsterlaD
Copy link
Contributor Author

OsterlaD commented Oct 4, 2016

Well, this would be my solution without changes to cmake.
If you decide that it is better to change cmake behavior, then reject this pull request.
Currently it is documented to copy module config and udev rules by hand.
If you want to change this behavior #485 is to prefer.
If you want to keep this behavior then this pull request is to prefer.

@xor-gate
Copy link
Member

xor-gate commented Oct 4, 2016 •
edited

I understand your concern about not touching cmake for the debian packaging. But I prefer fixing cmake for all platforms and debian packaging "at the same time". My decision is to get PR #485 ready. You may ask @nekromant if there are things you would like to see fixed or added.

@xor-gate xor-gate closed this Oct 4, 2016
@Nightwalker-87 Nightwalker-87 changed the title Build debian package with more use of cmake packaging: Build debian package with more use of cmake Mar 17, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.3.0 milestone Mar 17, 2020
@Nightwalker-87
Copy link
Member

Closed in favour of #485.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
code/feature-request os/linux status/rejected status/resolved
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OsterlaD @xor-gate @Nightwalker-87 @nekromant