Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use %zx because it's unsupported on mingw64 #578

Merged
merged 6 commits into from
Mar 24, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 24, 2017

Also check that no warnings happen on travis

cc #569

Also check that no warnings happen on travis
@xor-gate
Copy link
Member

Looks good i'm only not 100% sure if clang or other strict compiler will eat this. You should prefer adding a size to the cast so:

(unsigned) becomes (unsigned int)

Then we are good to go.

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 24, 2017

Ok... so after this PR:

  • travis will check gcc and clang on both linux and os-x
  • all compilations must be warning free
  • O2 is used instead of O3 optimizations (this was intended by the CMakeLists.txt, but never actually called due to elseif() not doing the same as else()

i'm only not 100% sure if clang or other strict compiler will eat this.

clang accepted it, but I still made the change.

Maybe there's a warning we can enable to enforce this?

@xor-gate xor-gate merged commit 78ced6a into stlink-org:master Mar 24, 2017
@xor-gate
Copy link
Member

Thank you for this improvement and understanding!

@xor-gate
Copy link
Member

I'm not sure, probably GCC or some analyser have warned me some day about no defined typed, assuming int.

@xor-gate xor-gate added this to the v1.3.2 milestone Mar 24, 2017
@Nightwalker-87 Nightwalker-87 linked an issue Apr 9, 2020 that may be closed by this pull request
6 tasks
@Nightwalker-87 Nightwalker-87 linked an issue Apr 10, 2020 that may be closed by this pull request
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inappropriate driver is taken on using v1.3.0 Windows MinGW64 executables have problems
3 participants