-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use %zx
because it's unsupported on mingw64
#578
Conversation
Also check that no warnings happen on travis
Looks good i'm only not 100% sure if clang or other strict compiler will eat this. You should prefer adding a size to the cast so:
Then we are good to go. |
Ok... so after this PR:
clang accepted it, but I still made the change. Maybe there's a warning we can enable to enforce this? |
Thank you for this improvement and understanding! |
I'm not sure, probably GCC or some analyser have warned me some day about no defined typed, assuming int. |
Also check that no warnings happen on travis
cc #569