Fix installation path for shared objects #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will break on non-linux systems, MinGW, Cygwin, OS X, BSD etcetera. Probably the library path should be injected during build by commandline arguments by distro maintainers instead of hardcoding /usr/lib64. |
xor-gate
requested changes
Apr 3, 2017
On 64bit linux all shared objects should go to /usr/lib64. With this path package maintainters should be able to override library path by setting STLINK_LIBRARY_PATH.
|
I have updated this pull request. It should now behave exactly as before with only one small change. Package maintainers should now be able to override library path using STLINK_LIBRARY_PATH variable. |
|
Looks good, |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no way to reliably configure installation path for shared
objects. It looks like this should be configurable by setting
CMAKE_LIBRARY_PATH but this approach doesn't work as intended.
Moreover, according to cmake docs, purpose of this variable is slightly
different.
With this patch it should be possible to configure where all libs should
go by setting STLINK_LIBRARY_PATH to either /usr/lib or /usr/lib64
(/usr/lib64 is new default value assuming that most users run 64bit
systems).