skip GTK detection if we're cross-compiling #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that stlink cannot use CMake's standard mechanism to find GTK3. Cmake's GTK3 detection supports only Unix at the moment. Therefore, stlink uses pkg-config to find GTK3. The downside of this is that Cmake's cross-compiler settings are not taken into account. Even if we're cross-compiling, CMake will find a local installation of GTK3 and compilation of the GUI fails. As a simple fix, we skip the GTK3 detection if we're cross-compiling. (In the long run, we should use a more advanced mechanism to find GTK3.)
xor-gate
approved these changes
May 5, 2017
|
Thanks! |
Nightwalker-87
added
bug/compilation
bug/fixed
component/stlink-gui
status/resolved
error/compilation
and removed
bug/compilation
bug/fixed
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that stlink cannot use CMake's standard mechanism to find GTK3.
Cmake's GTK3 detection supports only Unix at the moment.
Therefore, stlink uses pkg-config to find GTK3. The downside of this is
that Cmake's cross-compiler settings are not taken into account. Even if
we're cross-compiling, CMake will find a local installation of GTK3 and
compilation of the GUI fails.
As a simple fix, we skip the GTK3 detection if we're cross-compiling.
(In the long run, we should use a more advanced mechanism to find GTK3.)