Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to SYS_READ changes in PR #727 per review. #729

Merged
merged 6 commits into from
Jul 28, 2018
Merged

Fixes to SYS_READ changes in PR #727 per review. #729

merged 6 commits into from
Jul 28, 2018

Commits on Jul 26, 2018

  1. Use local variable for read_result instead of *ret, and fix 

    calculation of *ret for EOF case.
    @donmr
    donmr committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    c1abc8a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/texane/stlink

    @donmr
    donmr committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    185b02f View commit details
    Browse the repository at this point in the history

  3. Found a problem when reading an odd (%4) number of bytes at the end 

    of a file.  fread (on stm32) get them (say 3 bytes), then askes for
more.  do_semihosting gets a read return of 0 and tries to write that.
mem_write alters the address to be aligned and overwrites then 3 bytes
from the last read.

This change simply tells mem_write to do nothing if len is 0.
    @donmr
    donmr committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    a20d499 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. Fix Issues from Fabien-Chouteau's review of my previous patch in isue s… 

    …tlink-org#727.
    @donmr
    donmr committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    dc89eda View commit details
    Browse the repository at this point in the history

  2. Revert change to mem_write() so it does not confuse fixes to do_semih… 

    …osting().
    @donmr
    donmr committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    9058556 View commit details
    Browse the repository at this point in the history

  3. Add cast to avoid warning.

    @donmr
    donmr committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    44b3392 View commit details
    Browse the repository at this point in the history