Fix to cast in changes for SYS_READ. #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculation of *ret for EOF case.
of a file. fread (on stm32) get them (say 3 bytes), then askes for more. do_semihosting gets a read return of 0 and tries to write that. mem_write alters the address to be aligned and overwrites then 3 bytes from the last read. This change simply tells mem_write to do nothing if len is 0.
Fixes to SYS_READ changes in PR stlink-org#727 per review. (stlink-org#729)
and the compiler should be fine with that without any cast.
1 task
|
Thanks! |
6 tasks
Nightwalker-87
added
bug/fixed
status/resolved
code/compilation-warning
and removed
bug/fixed
labels
1 task
Nightwalker-87
added
bug/compilation
bug/fixed
code/compilation-warning
and removed
code/compilation-warning
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As slyshykO notes in #729, read_result is a signed type so the -1 constant should not be cast to unsigned.
I belive compilers will be happy with this without any cast.