Only do bank calculation on STM32L4 devices with dual banked flash / Added chip ID 0x464 for STM32L41xxx/L42xxx devices #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RM0394 covers the STM32L41xx, 42xx, 43xx, 44xx, 45xx, and 46xx. These devices are all employ single banked flash and have chip id's of 0x464 for the 41xx/42xx, 0x435 for 43xx/44xx, and 0x462 for 45xx/46xx It's also worth noting that bit 21 of the FLASH_OPTR register is marked as resevred for these chips, and isn't an indicator of dual banked flash. RM0392 covers the STM32L4x1, cpu_id 0x415 and can be dual banked. RM0351 covers the STM32L4x5/4x6, cpu_ids 0x415 & 0x461 and can be dual banked RM0432 covers the STM32L4Rx/4Sx, cpu_id 0x470 and can be dual banked. This PR modifies the calculate_L4_page functio to only factor bank calculations for the devices above which can support dual banked flash.
dhylands
changed the title
dhylands
changed the title
|
I tested this on a NUCLEO-L432KC (single banked device) and NUCLEO-L476RG (dual banked device). |
|
This fixes #750 |
xor-gate
requested changes
Dec 14, 2018
|
Whoops - thanks for noticing that. My editor inserted tabs instead of spaces. Fixed. |
|
Thanks! |
6 tasks
Nightwalker-87
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RM0394 covers the STM32L41xx, 42xx, 43xx, 44xx, 45xx, and 46xx. These
devices are all employ single banked flash and have chip id's
of 0x464 for the 41xx/42xx, 0x435 for 43xx/44xx, and 0x462 for 45xx/46xx
It's also worth noting that bit 21 of the FLASH_OPTR register is marked
as resevred for these chips, and isn't an indicator of dual banked
flash.
RM0392 covers the STM32L4x1, cpu_id 0x415 and can be dual banked.
RM0351 covers the STM32L4x5/4x6, cpu_ids 0x415 & 0x461 and can be dual
banked
RM0432 covers the STM32L4Rx/4Sx, cpu_id 0x470 and can be dual banked.
This PR modifies the calculate_L4_page functio to only factor bank
calculations for the devices above which can support dual banked flash.
I also checked the STM32L4 HAL code and it uses the following preprocessor #if statment
to identify dual-banked devices,