Added call to clear PG bit after Writing to Flash #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ronnymajani ! |
Nightwalker-87
added
bug/fixed
component/st-flash
status/resolved
code/feature-request
and removed
bug/fixed
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The st-flash write utility wasn't clearing the PG bit after it finished writing to Flash.
Luckily you've already implemented the function for clearing the PG bit, so I just added the call right before locking Flash CR again.
The reason this is important is that if I just flashed a firmware, then any subsequent operation will fail, until I clear the PG bit, so I'll have to add code just for that one case. Or a simple power cycle the STM32 clears it.
Anyway it's just a convenience for the flasher utility to clean up after itself :)