Fixed broken build on 32-bit systems #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyshykO
reviewed
Apr 11, 2020
Nightwalker-87
changed the title
Nightwalker-87
approved these changes
Apr 12, 2020
|
I think we should add such configuration to Travis build. UPDATE: |
|
Yes @slyshykO, it should be regularly tested with Travis. I agree on that. |
|
Thanks for fixing this! 👍 To be honest, we should change some variables to the appropriate sizes / datatypes. The requirement for manual casts not only here, but at several places throughout the codebase, indicates that something is not as it is supposed to be per design. If implemented nicely, there hardly is any need for explicit casting. I'd like to see that addressed in v1.6.2 at a later point in time, maybe within #909. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919