flash.c: stlink_open_usb is actually able to open v1 and v2 (and v3) #922
Conversation
Nightwalker-87
added
code/feedback
code/refactoring
component/st-flash
programmer/STLINK/V1
|
This is actually a result of #918, right? |
|
i think it was half-working before my previous PR - i'm pretty sure i managed to use a v1 without specifying any device path, at least this could work in specific conditions. |
|
@grevaillot: Can you update this PR to resolve the conflict in |
|
pr conflict fixed - not much time to scan old tickest - This can probably close initial issue of #378 - v1/v2 selection issue. Still, switching to something "working" to parse cmdline opt would be nice, but we now avoid that bug. |
….) devices. no need to check that _not used_ o.devname .. no need to specify devname in commandline get rid of the devname cmdline stuff, and update comments
grevaillot
force-pushed
the
to_merge/st-flash_v1v2
branch
from
e6750c4
to
fc507fd
Compare
Thx, not necessary for you to do so, I think we're fine to link #378 here. Any further more general improvements for opt parsing should be addressed by a new ticket, should such be desired. |
|
Merci @grevaillot! |
flash.c: stlink_open_usb is actually able to open v1 and v2 (and v3 .…….)** devices.
no need to check that not used o.devname ..
no need to specify devname in commandline
get rid of the devname cmdline stuff, and update comments
should probably help with #378 ..