Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for static linking of libssp #974

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fix for static linking of libssp #974

merged 2 commits into from
Jun 3, 2020

Conversation

slyshykO
Copy link
Collaborator

@slyshykO slyshykO commented Jun 2, 2020

Try to fix #973 .

@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone Jun 2, 2020
@Nightwalker-87
Copy link
Member

@blacklion: Please test if this resolves the problem.
In general we should have no static linking in FreeBSD.
The following could be related to libusb being integrated in FreeBSD which may also affect the way of linking:

ld: error: attempted static link of dynamic object /usr/lib/libusb.so
cc: error: linker command failed with exit code 1 (use -v to see invocation)

@Nightwalker-87 Nightwalker-87 changed the title Fix static Fix for static linking of libssp Jun 2, 2020
@blacklion
Copy link

Yes, it helps!

BTW, looks like you forgot add cmake/pkgconfig as subdirectory to main CMakeLists.txt

@blacklion blacklion mentioned this pull request Jun 3, 2020
Closed
@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Jun 3, 2020 •
edited
Loading

BTW, looks like you forgot add cmake/pkgconfig as subdirectory to main CMakeLists.txt

No, this is obsolete - see #971.

@Nightwalker-87 Nightwalker-87 merged commit b0dcb0c into stlink-org:develop Jun 3, 2020
@Nightwalker-87
Copy link
Member

Thank you @slyshykO ! 🎉

@slyshykO slyshykO deleted the fix_static branch June 19, 2020 06:12
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nightwalker-87 Nightwalker-87 Nightwalker-87 approved these changes

Assignees

@slyshykO slyshykO

Labels
bug/compilation bug/fixed os/linux os/macOS os/windows status/resolved-verified
Projects
No open projects
Release v1.7.0
Status: Done
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

FreeBSD: Can not build release 1.6.1 due to wrong configuration prepared by CMake
3 participants
@slyshykO @Nightwalker-87 @blacklion