Merge pull request #489 from nhpupu/fix-flash

Fix flash error flag clearing
stm32-rs · Jul 16, 2024 · d50ccba · d50ccba
2 parents 86b1686 + 10a2d02
commit d50ccba
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Replace UB code by a legitimate pointer access
 - Reexport `Direction` from `qei`
 - Add dac
+- Fix flash error flag clearing
 
 ## [v0.10.0] - 2022-12-12
 

diff --git a/src/flash.rs b/src/flash.rs
@@ -166,7 +166,8 @@ impl<'a> FlashWriter<'a> {
         self.lock()?;
 
         if sr.wrprterr().bit_is_set() {
-            self.flash.sr.sr().modify(|_, w| w.wrprterr().clear_bit());
+            // reset by writing 1
+            self.flash.sr.sr().modify(|_, w| w.wrprterr().bit(true));
             Err(Error::EraseError)
         } else {
             if self.verify {
@@ -257,12 +258,14 @@ impl<'a> FlashWriter<'a> {
 
             // Check for errors
             if self.flash.sr.sr().read().pgerr().bit_is_set() {
-                self.flash.sr.sr().modify(|_, w| w.pgerr().clear_bit());
+                // reset by writing 1
+                self.flash.sr.sr().modify(|_, w| w.pgerr().bit(true));
 
                 self.lock()?;
                 return Err(Error::ProgrammingError);
             } else if self.flash.sr.sr().read().wrprterr().bit_is_set() {
-                self.flash.sr.sr().modify(|_, w| w.wrprterr().clear_bit());
+                // reset by writing 1
+                self.flash.sr.sr().modify(|_, w| w.wrprterr().bit(true));
 
                 self.lock()?;
                 return Err(Error::WriteError);