Mark Gpiox as Send and Sync #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellmcc
force-pushed
the
make-pxx-send-and-sync
branch
2 times, most recently
from
0e1c29d
to
6ab7373
Compare
Sh3Rm4n
requested changes
Jul 9, 2021
|
Thanks for the review! No preference on my end between you merging this with CI failures or rebasing after the CI fix. Let me know. |
|
Let's rebase then :) |
russellmcc
force-pushed
the
make-pxx-send-and-sync
branch
2 times, most recently
from
b5c607a
to
bc5c2ef
Compare
This is appropriate because we only ever perform atomic operations on these registers. This allows `PXx` to be Send + Sync.
Sh3Rm4n
force-pushed
the
make-pxx-send-and-sync
branch
from
bc5c2ef
to
a8c43d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is appropriate because we only ever perform atomic operations on
these registers. This allows
PXxto be Send + Sync.Closes #249