Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analog gpio mode #33

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Add analog gpio mode #33

merged 2 commits into from
Nov 26, 2019

Conversation

russellmcc
Copy link
Contributor

This is necessary when you're using a DAC.

@strom-und-spiele
Copy link
Collaborator

This is also needed for ADC, and I did (partly verbatim :) ) the same implementation:
https://github.com/strom-und-spiele/stm32f3xx-hal/blob/adc/src/gpio.rs
would suggest to also add pupdr to into_analog.
As stated in table 72 in the reference manual, only 0b00 (floating) is a valid
config if the pin is set to analog mode.

@russellmcc
Copy link
Contributor Author

Thanks, you are of course correct. I've added pupdr configuration.

@dfrankland dfrankland merged commit 5bd959a into stm32-rs:master Nov 26, 2019
@dfrankland
Copy link
Member

@strom-und-spiele, @russellmcc, I think y'all might be even better suited than myself to help run this repo. Would either of you be interested in being added as collaborators?

@strom-und-spiele
Copy link
Collaborator

Thanks for the praise - I'm actually interested in being able to create PRs, but I'm still deep in the "aah - so this is how that works" stadium ;)

@russellmcc
Copy link
Contributor Author

Mostly I'm hesitant due to plenty of other commitments for my time, but if you don't mind a somewhat lackadaisical collaborator I'd be happy to help out - I just can't promise I'll be able to devote any significant time to it.

@dfrankland
Copy link
Member

@russellmcc I am looking for folks who know more about embedded development, since I am mostly a beginner myself. No commitments needed, just a review here and there. Although, you don't need to be a collaborator to review code 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants