-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SPI initialization to be MSB first #60
Conversation
With master + this change, I can successfully communicate with two different SPI devices using an STM32F334 |
Thank you for this PR. Sorry for the delay, I was quite busy with work and uni stuff the last weeks. It seems like I oversaw this, when I changed these lines. I briefly tested it today and it seems to fix the SPI issue. I will look into this PR this week :) |
Okay I've confirmed that your fix is working. Would be strange, if not 😅 I would be happy, if you added a note to the changelog. Something like:
:) |
Thanks! Meh travis timed out. Force pushing with I should look into fixing travis sometime, as two instances doing the sames is really not useful 😅 |
Thanks for force pushing. This sadly didn't help. The travis instance has a hard time initializing sscache. I'll look into fixing this. |
For now this seems to time out the travis instance, so the build will not succeed. Disable it for now until this issue is resolved.
Disable caching in travis worked 🎉 |
The comments indicate that the code is attempting to set the SPI order to MSB first, however it actually sets it to LSB first. Since most devices are MSB first, this is the correct choice.
Closes #59.