Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPIO speed into SPI example, improve docs. #576

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Add GPIO speed into SPI example, improve docs. #576

merged 2 commits into from
Mar 12, 2023

Conversation

qwerty19106
Copy link
Contributor

Fix 'wrong last bit in every received byte' problem, see #564 for details.

@qwerty19106
Copy link
Contributor Author

@burrbull
Spi::new has not docs, and the pins param consumes Pin with any mode.
I can add Spi::new docs with inline example, or you will change Spi::new API?

@burrbull
Copy link
Member

any doc improvements are appreciated

@burrbull
Copy link
Member

Fix errors, please.

@burrbull burrbull marked this pull request as ready for review March 12, 2023 19:14
@burrbull
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 12, 2023

Build succeeded:

@bors bors bot merged commit d2b0266 into stm32-rs:master Mar 12, 2023
@qwerty19106 qwerty19106 deleted the improve_spi_docs_example branch March 14, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwerty19106 @burrbull