move PWM pins connecting after inialization #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
pwm-pins-after
branch
2 times, most recently
from
c564f07 to
328bce5
Compare
Closed
burrbull
force-pushed
the
pwm-pins-after
branch
from
328bce5 to
d982c91
Compare
burrbull
commented
Aug 7, 2024
| pub fn set_duty(&mut self, duty: u16) { | ||
| TIM::set_cc_value(C, duty as u32) | ||
| } | ||
| self.tim.start_pwm(); |
There was a problem hiding this comment.
Should it be stopped here? Add pub fn start/stop ?
burrbull
force-pushed
the
pwm-pins-after
branch
from
d982c91 to
8398190
Compare
burrbull
force-pushed
the
pwm-pins-after
branch
from
8398190 to
9155262
Compare
rursprung
added a commit
to rursprung/tb6612fng-rs
that referenced
this pull request
Oct 8, 2024
this is a breaking change. see stm32-rs/stm32f4xx-hal#791 for details.
rursprung
added a commit
to rursprung/tb6612fng-rs
that referenced
this pull request
Oct 8, 2024
this is a breaking change. see stm32-rs/stm32f4xx-hal#791 for details.
rursprung
added a commit
to rursprung/tb6612fng-rs
that referenced
this pull request
Oct 12, 2024
this is a breaking change and thus needs some manual changes. see stm32-rs/stm32f4xx-hal#791 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is from stm32-rs/stm32f3xx-hal#34 but with several changes.
Always split PWM on manager and channels.
The main disadvantage is removed
embedded_hal_02::Pwmas no morePwmstruct.cc @apollolabsdev @kossnikita