Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding clippy warnings #128

Merged
merged 4 commits into from
Aug 4, 2024

Conversation

liamkinne
Copy link
Contributor

@liamkinne liamkinne commented Jul 27, 2024

  • Fix feature names for chip variant stm32g4A1 -> stm32g4a1 and some typos of stm32g49a.
  • Fix comment indentation in comments
  • Fix missing type in mem::transmute use

@liamkinne
Copy link
Contributor Author

@ryan-summers a PR for you to look at, please.

CI issues are unrelated. Will fix them in another PR.

@ryan-summers
Copy link
Member

Pinging some of the original contributors for this HAL - The other asked about maintainership of this HAL on the Rust Embedded matrix channel. @usbalbin, @no111u3, and @dotcypress are any of you still maintaining this crate and are you available for review?

@usbalbin
Copy link
Contributor

Does this build for the stm32g4a1 and stm32g491? I believe there were quite a lot of issues when I updated the CI to run for all devices so I excluded them. There is also #77 trying to atleast get them to compile, not sure if anything has changed since i worked on that.

BTW, I am happy to review but I do not have permissions to merge things

@liamkinne
Copy link
Contributor Author

@usbalbin you are correct. I've rolled back the commit stating support for the stm32g4a1 in the readme. Otherwise this PR is just to fix the warnings thrown up by the CI.

@liamkinne liamkinne force-pushed the fix-feature-flag-part-numbers branch from 8f5bd60 to bb620c0 Compare July 27, 2024 14:56
Copy link
Contributor

@usbalbin usbalbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usbalbin
Copy link
Contributor

I will try posting a PR trying to fix the clippy warnings unless someone else does it first

@liamkinne
Copy link
Contributor Author

@usbalbin I'm happy to do that next. Just wanted to get this one sorted out before I start spamming this repo with PRs.

@usbalbin
Copy link
Contributor

Awesome :)

@adamgreig
Copy link
Member

@usbalbin, would you be interested in helping maintain this crate (and so getting permission to review/merge)?

@usbalbin
Copy link
Contributor

@usbalbin, would you be interested in helping maintain this crate (and so getting permission to review/merge)?

Yes, I would :)

Expect no miracles but I am happy to try to help.

@usbalbin
Copy link
Contributor

usbalbin commented Aug 4, 2024

@adamgreig is there anythig I need to do to get access(assuming you want me to)?

@liamkinne liamkinne changed the title Fix feature flag part numbers for stm32g4a1 Fix outstanding clippy warnings Aug 4, 2024
Copy link
Contributor

@usbalbin usbalbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :)

@adamgreig
Copy link
Member

@adamgreig is there anythig I need to do to get access(assuming you want me to)?

I've invited you to join the team, you should have got an email or maybe can see the invitation at https://github.com/stm32-rs/?

@usbalbin
Copy link
Contributor

usbalbin commented Aug 4, 2024

@adamgreig is there anythig I need to do to get access(assuming you want me to)?

I've invited you to join the team, you should have got an email or maybe can see the invitation at https://github.com/stm32-rs/?

Thank you :)

@usbalbin
Copy link
Contributor

usbalbin commented Aug 4, 2024

Any preferences for merge method?

@adamgreig
Copy link
Member

I usually do a regular merge (no squash or rebase) but I'm not picky and it's not really for me to say here; perhaps stick to whatever has been done historically here unless you have strong feelings about doing it differently.

@usbalbin usbalbin merged commit 93973df into stm32-rs:main Aug 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants