CI

[usbalbin]

• Add g491 and 4a1 to ci, check examples, check with different feature sets

• Remove unused feature embedded-can-03

• Remove feature unstable-defmt from ci

• Add clippy to ci

• Fix warning

Fail on CI

[usbalbin]

I might have resolved those remaining warnings somewhere in my messy branch with too many changes. Will try to take a look later..

[usbalbin]

Seems like log-itm's println requires a logger as parameter.

error: unexpected end of macro invocation
  --> examples/button.rs:80:26
   |
80 |     println!("Start Loop");
   |                          ^ missing tokens in macro arguments
   |
note: while trying to match `,`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cortex-m-log-0.7.0/src/lib.rs:59:18
   |
59 |     ($logger:expr, $($arg:tt)+) => ({
   |                  ^

None of the examples are made with that in mind.

Any advice on how to proceed?

[usbalbin]

Btw, https://github.com/DoumanAsh/cortex-m-log seems to be not so active. Not sure how many users use that vs rtt or semihosting

[usbalbin]

As I see it, we have atleast two options:

1. Change utils::logger::init() to return the logger instance (if or () where not applicable) and add $logger as the first argument to all println impl's to make the syntax identical
2. Remove cortex-m-log as an option for our examples

@no111u3 do you have any suggestions? :)

[usbalbin]

As I see it, we have atleast two options:

1. Change utils::logger::init() to return the logger instance (if or () where not applicable) and add $logger as the first argument to all println impl's to make the syntax identical
2. Remove cortex-m-log as an option for our examples

@no111u3 do you have any suggestions? :)

It was possible to work around the issue by making println use log::info which does not need a logger instance (assuming logger::init has been called. So now CI passes!

This PR should now be ready for review :)