Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build on stable #6

Closed
richardeoin opened this issue Jun 13, 2019 · 3 comments · Fixed by #38
Closed

Doesn't build on stable #6

richardeoin opened this issue Jun 13, 2019 · 3 comments · Fixed by #38
Assignees

Comments

@richardeoin
Copy link
Member

Currently nightly is required for type_alias_enum_variants.

type_alias_enum_variants

Tracking issue
Stabilisation PR

@richardeoin richardeoin changed the title Doesn't build on stable Rust Doesn't build on stable Jun 13, 2019
@richardeoin richardeoin self-assigned this Jun 13, 2019
jordens added a commit that referenced this issue Jul 3, 2019
None of this will succeed until #5 is resolved.

Stable builds will only succeed once #6 is resolved.
jordens added a commit that referenced this issue Jul 3, 2019
This matches the currently targeted dependencies/rust versions.
It should be removed once #5 and #6 are resolved.
@jordens
Copy link
Member

jordens commented Jul 6, 2019

Stabilized in rust-lang/rust@5748825. Will appear in Rust 1.37.0

@jordens
Copy link
Member

jordens commented Jul 11, 2019

Now that there is a 1.37 beta we can use that in CI.

jordens added a commit that referenced this issue Jul 12, 2019
bors bot added a commit that referenced this issue Jul 12, 2019
18: travis: run on beta (#6) r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
@richardeoin
Copy link
Member Author

Rust 1.37.0 stable was released on 15th August 2019

bors bot added a commit that referenced this issue Sep 12, 2019
38: [rust] Rust 1.37.0 stable was released on 15th August 2019 r=jordens a=richardeoin

https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html

Closes #6

Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
@bors bors bot closed this as completed in 5aee78b Sep 12, 2019
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
None of this will succeed until stm32-rs#5 is resolved.

Stable builds will only succeed once stm32-rs#6 is resolved.
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
This matches the currently targeted dependencies/rust versions.
It should be removed once stm32-rs#5 and stm32-rs#6 are resolved.
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
18: travis: run on beta (stm32-rs#6) r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this issue Jul 9, 2020
38: [rust] Rust 1.37.0 stable was released on 15th August 2019 r=jordens a=richardeoin

https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html

Closes stm32-rs#6

Co-authored-by: Richard Meadows <962920+richardeoin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants