Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose factory calibration data #121

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Expose factory calibration data #121

merged 1 commit into from
Oct 16, 2020

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Aug 5, 2020

This PR exposes the factory calibration data.

Verified to be working on an STM32L071KBTx. As a cross-check, I verified the memory addresses against the datasheet of the (randomly picked) STM32L053C6, they match.

2020-08-05-233719_346x79_scrot

Strongly inspired by the signature module in https://github.com/stm32-rs/stm32f4xx-hal/blob/master/src/signature.rs.

Fixes #120.

CC @rnestler

@dbrgn dbrgn added the enhancement New feature or request label Aug 5, 2020
@dbrgn dbrgn requested a review from hannobraun August 5, 2020 21:41
Copy link
Contributor

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked against the reference manual, but looks good otherwise. Some minor confusion about the documentation (see comments).

src/calibration.rs Outdated Show resolved Hide resolved
src/calibration.rs Outdated Show resolved Hide resolved
src/calibration.rs Outdated Show resolved Hide resolved
src/calibration.rs Outdated Show resolved Hide resolved
@dbrgn dbrgn self-assigned this Oct 15, 2020
Verified to be working on an STM32L071KBTx. As a cross-check, I verified
the memory addresses against the datasheet of the (randomly picked)
STM32L053C6, they match.
@dbrgn
Copy link
Contributor Author

dbrgn commented Oct 15, 2020

Docs improved and branch rebased against master!

@dbrgn dbrgn requested a review from hannobraun October 15, 2020 23:32
Copy link
Contributor

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still haven't checked this against the reference manual, but everything looks good to me now. Thank you, @dbrgn!

@hannobraun hannobraun merged commit 5e32fa4 into master Oct 16, 2020
@hannobraun hannobraun deleted the calibration branch October 16, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register definitions for factory option bytes
3 participants