Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GD32VF103 chips [rebase] #36

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

katyo
Copy link

@katyo katyo commented Feb 4, 2023

This is rebase of original PR #25.

I tested it with test class example.
Also I tested CDC ACM made using usbd_serial crate (usb-otg-workspace#7)

@katyo katyo changed the title Gd32v ng 2 Add support for GD32VF103 chips [rebase] Feb 4, 2023
@katyo
Copy link
Author

katyo commented Feb 4, 2023

@Disasm I would like integrate OTG FS support directly to gd32vf103xx-hal crate.
Any chace to merge this PR or original one soon?

@Disasm
Copy link
Member

Disasm commented Feb 5, 2023

The biggest problem so far is testing: I'd like the PR to be tested before merge, not only with GD32V, but also with other STM32 chips to avoid regressions. I have the hardware needed, but I need time which I don't have enough at the moment.

@katyo
Copy link
Author

katyo commented Mar 23, 2023

@Disasm I developing CI solution for running tests on hardware.
Could you list microcontrollers/eval boards needed for that project?

@Disasm
Copy link
Member

Disasm commented Mar 25, 2023

I used the following chips/boards:
STM32F401 (WeAct Black Pill)
STM32F407 (XCore407I) - external PHY support testing
STM32F429 (NUCLEO-F429ZI)
STM32F446 (NUCLEO-F446ZE)
STM32F723 (32F723EDISCOVERY) - internal HS+FS PHY testing
GD32VF103 (Longan Nano)

Also I don't have a board for STM32H7xx, but it would be nice to test it as well (#4, stm32-rs/stm32h7xx-hal#108)

@katyo
Copy link
Author

katyo commented Mar 25, 2023

@Disasm Thanks!

Currently I have only the following:

  • STM32F401 (WeAct Black Pill)
  • STM32F407 (XCore407I) - external PHY support testing
  • STM32F411 (Black Pill)
  • STM32F429 (NUCLEO-F429ZI)
  • STM32F446 (NUCLEO-F446ZE)
  • STM32F723 (32F723EDISCOVERY) - internal HS+FS PHY testing
  • GD32VF103 (Longan Nano)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants