Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update after arduino-cli change #1107

Merged
merged 5 commits into from
Jul 3, 2020
Merged

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 29, 2020

With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687

Harden the exception management to have a better output result.

@fpistm fpistm added enhancement New feature or request fix 🩹 Bug fix labels Jun 29, 2020
@fpistm fpistm added this to the 2.0.0 milestone Jun 29, 2020
@fpistm fpistm force-pushed the CLI_output branch 3 times, most recently from c82ae8d to 2dd9039 Compare July 1, 2020 15:37
@fpistm fpistm marked this pull request as draft July 1, 2020 15:45
@fpistm
Copy link
Member Author

fpistm commented Jul 1, 2020

Build with arduino-cli 0.11.0 failed, it seems there is a regression with the arduino-cli: arduino/arduino-cli#759

@fpistm fpistm force-pushed the CLI_output branch 4 times, most recently from 929283e to 14b7e4f Compare July 2, 2020 15:57
Since arduino-cli v0.11.0 '-o' options has been removed.
The script does not handle properly this case which raised
a command usage error.

Error: unknown shorthand flag: 'o' in -o
Usage:
  arduino-cli compile [flags]

So this fix allows to properly handle it.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
With new arduino-cli v0.11.0, output management has changed.
See arduino/arduino-cli#687

Binaries are always copied.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
If the executed command failed return the output and the error code.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm changed the title [CI] Update binary management after cli change. [CI] Update after cli change. Jul 2, 2020
@fpistm fpistm changed the title [CI] Update after cli change. [CI] Update after arduin-cli change Jul 2, 2020
@fpistm fpistm marked this pull request as ready for review July 2, 2020 16:28
@fpistm fpistm changed the title [CI] Update after arduin-cli change [CI] Update after arduino-cli change Jul 2, 2020
@fpistm fpistm merged commit 73f76d6 into stm32duino:master Jul 3, 2020
@fpistm fpistm deleted the CLI_output branch July 3, 2020 09:01
@fpistm fpistm mentioned this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix 🩹 Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant