Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define generic boards for STM32L051K8U and -T #2395

Closed
wants to merge 1 commit into from

Conversation

ademuri
Copy link
Contributor

@ademuri ademuri commented Jun 7, 2024

Summary

This PR adds loader scripts for the STM32L051K(6-8)U and STM32L051K(6-8)T variants. They are generated using STM32Cube, following the documentation in the wiki.

@fpistm
Copy link
Member

fpistm commented Jun 10, 2024

Hi @ademuri
Thanks for the PR, anyway it is not complete, you have to add a default clock config, declare the variant and add them to the README.
https://github.com/stm32duino/Arduino_Core_STM32/wiki/Add-a-new-variant-(board)#3---generic-system-clock-configuration

@fpistm fpistm marked this pull request as draft June 11, 2024 15:21
@fpistm
Copy link
Member

fpistm commented Jun 14, 2024

Close it as no feedback from OP. PR not complete as stated in previous comment. Update your branch then PR can be reopened.

@fpistm fpistm closed this Jun 14, 2024
@ademuri ademuri changed the title Add ldscript.ld for STM32L051K(6-8)U and -T Define generic boards for STM32L051K8U and -T Jun 19, 2024
@ademuri
Copy link
Contributor Author

ademuri commented Jun 19, 2024

I've updated this pull request with the other changes, and this is ready for review.

@fpistm
Copy link
Member

fpistm commented Jun 19, 2024

No change at this time.

@ademuri
Copy link
Contributor Author

ademuri commented Jun 19, 2024

Hmm, that's odd - I updated the branch that this PR is based on, but this PR did not update. Instead created a new pull request: #2405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants