Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F103Zx support #851

Merged
merged 2 commits into from
Jan 30, 2020
Merged

F103Zx support #851

merged 2 commits into from
Jan 30, 2020

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jan 3, 2020

Add Generic F103Zx support and VCCGND_F103ZET6 (Mini)

I have not this boards so if someone could do some tests that's would be fine.
Thanks.

@fpistm fpistm added the new variant Add support of new bard label Jan 3, 2020
@fpistm fpistm force-pushed the Gen_F103Zx branch 2 times, most recently from d209195 to a65e03c Compare January 3, 2020 14:11
@fpistm
Copy link
Member Author

fpistm commented Jan 3, 2020

@dds90 could you test this please?

@dds90
Copy link
Contributor

dds90 commented Jan 4, 2020

Hi @fpistm,
thanks for your contribute.

At the moment I've tested some peripherials in VCCGND_F103ZET6 (Mini):

  • SD seems work correctly
  • The Analog pins connected to ADC2 and ADC3 lock the Serial
  • Second and Third serial not work yet.

@fpistm
Copy link
Member Author

fpistm commented Jan 4, 2020

How did you test the other serial ?

@dds90
Copy link
Contributor

dds90 commented Jan 4, 2020

Like this:

void setup() {
Serial.begin(19200);   // on PA9 PA10
Serial2.begin(19200);  // on PA3 PA2
Serial3.begin(19200);  // on PB11 PB10

Serial.println("Serial");
Serial2.println("Serial2");
Serial3.println("Serial3!");
}

void loop() {
}

@fpistm
Copy link
Member Author

fpistm commented Jan 4, 2020

That's what I thought.
By default only one Serial instance is instantiate.
In this case Serial1 using USART1 on PA10/PA9.

To use other Serial you have to instantiate them:

HardwareSerial Serial2(PA3, PA2);
HardwareSerial Serial3(PB11, PB10);

@dds90
Copy link
Contributor

dds90 commented Jan 4, 2020

Thanks again.
With your code and only Serial and Serial2 work well.
But when I add the Serial3 instance , it send only one character, and Serial and Serial2 send only two characters.

@fpistm
Copy link
Member Author

fpistm commented Jan 27, 2020

@dds90
I've tested with a VCC GND F103ZE and all Serials works.

@dds90
Copy link
Contributor

dds90 commented Jan 27, 2020

@fpistm
Please can you share your testing code?
Did you tested the the analog pins also?

@fpistm
Copy link
Member Author

fpistm commented Jan 27, 2020

This is the same than the one you provided adding the fix I gave you. ADC is working except ADC3 which is a know issue

@fpistm
Copy link
Member Author

fpistm commented Jan 28, 2020

HardwareSerial Serial2(PA3, PA2);
HardwareSerial Serial3(PB11, PB10);

void setup() {
  Serial.begin(19200);   // on PA9 PA10
  Serial2.begin(19200);  // on PA3 PA2
  Serial3.begin(19200);  // on PB11 PB10

  Serial.println("Serial");
  Serial2.println("Serial2");
  Serial3.println("Serial3!");
}

void loop() {
}

@dds90
Copy link
Contributor

dds90 commented Jan 28, 2020

Many thanks!
For the serials i retry as soon as possible. For the ADC are there any chances to fix this issue?

@fpistm
Copy link
Member Author

fpistm commented Jan 28, 2020

For the serials i retry as soon as possible. For the ADC are there any chances to fix this issue?

Only ADC3 is not working ADC1 and 2 works fine anyway, I have currently no clue. As a workaround I will comment all ADC3 in the PeripheralPins.c

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@dds90
Copy link
Contributor

dds90 commented Jan 28, 2020

I confirm that all serials are ok.
In the previously test, i wrong to add the instances in to the setup function.

The pins from PF_6 to PF_10 can't remap to another ADC. Where did you read the ADC3 issue?

@fpistm
Copy link
Member Author

fpistm commented Jan 28, 2020

On the forum one member told that ADC3 doesn't work.Then I confirm, there is the same issue with Rogers's core.

@dds90
Copy link
Contributor

dds90 commented Jan 28, 2020

Is there the possibility that it is a bug in the STM32F1 series?

@fpistm
Copy link
Member Author

fpistm commented Jan 30, 2020

@dds90

Is there the possibility that it is a bug in the STM32F1 series?

Well, currently I don't know. All is possible anyway, the STM32F1 serie is old then I guess this kind of issue would be report in the errata sheet. So, we will investigate.

@fpistm fpistm merged commit 7b3efaa into stm32duino:master Jan 30, 2020
@fpistm fpistm deleted the Gen_F103Zx branch January 30, 2020 06:38
@dds90
Copy link
Contributor

dds90 commented Feb 9, 2020

@fpistm
Do you think it is necessary to open a new issue?

@fpistm
Copy link
Member Author

fpistm commented Feb 9, 2020

Issue is fixed.

@dds90
Copy link
Contributor

dds90 commented Feb 9, 2020

Oh, sorry.
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants