Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite default values to match other antenna configuration #10

Closed
ELV-Elektronik-AG opened this issue Jan 19, 2023 · 0 comments · Fixed by #11
Closed

Overwrite default values to match other antenna configuration #10

ELV-Elektronik-AG opened this issue Jan 19, 2023 · 0 comments · Fixed by #11
Labels
enhancement New feature or request
Milestone

Comments

@ELV-Elektronik-AG
Copy link
Collaborator

Hi,

to use the lib with the ELV-BM-TRX1 module, some default values have to be changed to match the hardware/antenna configuration.
Please add a preprocessor directive to overwrite the defines with own values or is there a other solution to use custom values?

in radio_conf.h
#define XTAL_DEFAULT_CAP_VALUE ( 0x20UL )

replace with
#ifndef XTAL_DEFAULT_CAP_VALUE
#define XTAL_DEFAULT_CAP_VALUE ( 0x20UL )
#endif /* XTAL_DEFAULT_CAP_VALUE */

if RegionEU868.h
#define EU868_TX_MAX_DATARATE DR_7
#define EU868_RX_MAX_DATARATE DR_7
#define EU868_DEFAULT_ANTENNA_GAIN 2.15f

replace with
#ifndef EU868_TX_MAX_DATARATE
#define EU868_TX_MAX_DATARATE DR_7
#endif /* EU868_TX_MAX_DATARATE */

#ifndef EU868_RX_MAX_DATARATE
#define EU868_RX_MAX_DATARATE DR_7
#endif /* EU868_RX_MAX_DATARATE*/

#ifndef EU868_DEFAULT_ANTENNA_GAIN
#define EU868_DEFAULT_ANTENNA_GAIN 2.15f
#endif /* EU868_DEFAULT_ANTENNA_GAIN */

Maybe for other hardware more values have to be changeable, but for the ELV-BM-TRX1 module only these values are important.

@fpistm fpistm added the enhancement New feature or request label Jan 24, 2023
@fpistm fpistm added this to the 0.1.1/0.2.0 milestone Jan 24, 2023
fpistm added a commit to fpistm/STM32LoRaWAN that referenced this issue Jan 27, 2023
Fixes stm32duino#10

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm added a commit that referenced this issue Jan 30, 2023
Fixes #10

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants