Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make getting Chassis collection work with DPU BMCs #323

Merged
merged 2 commits into from
Apr 30, 2024
Merged

make getting Chassis collection work with DPU BMCs #323

merged 2 commits into from
Apr 30, 2024

Conversation

iamsli
Copy link
Contributor

@iamsli iamsli commented Apr 30, 2024

This fixes the issue where we cannot get the Chassis collection for DPU BMCs.

Per Redfish docs, Controls should be a Link singular

Controls (v1.17+) { object The link to the collection of controls located in this chassis.
Contains a link to a resource.
@odata.id string read-only Link to Collection of Control. See the Control schema for
details.
}

Closes: #322

@stmcginnis
Copy link
Owner

Awesome, thanks for fixing it. Would you be able to pick up the other parts of #324? I'll close that one in favor of this PR.

Thanks!

@iamsli
Copy link
Contributor Author

iamsli commented Apr 30, 2024

oh i didn't even see that PR. Just made those changes, thanks!

@stmcginnis stmcginnis merged commit 2d5d848 into stmcginnis:main Apr 30, 2024
2 checks passed
@stmcginnis
Copy link
Owner

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error getting Chassis collection for DPU BMCs
2 participants