-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rtl] rework TWI module #340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚠️ * removed START done interrupt * removed STOP done interrupt
stnolting
added
HW
Hardware-related
optimization
Make things faster, smaller and more efficient
labels
Jun 9, 2022
To avoid hardware-vs-simulation mismatch. See #333
* set SDA LOW after a byte transmission to keep the bus claimed * add new status register flag to check if bus is currently claimed
* make sure TWI bus stays claimed (SDA = SCL = low) after a byte transmission * make sure the ACK sample time slot has the same "length" as the other data sampling time slots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
HW
Hardware-related
optimization
Make things faster, smaller and more efficient
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by the issues found in #339 this PR provides a complete makeover of the TWI module's hardware. These changes do not impact hardware utilization.
✔️ Optimizations and Fixes
✨ New Features
Exemplary TWI operation using the modified module from this PR:
START condition, transfer
0x70
, transfer0xF1
, STOP condition. TWI bus is not connected to any device; SDA and SCL are just connected to "pull-up resistors" (->'H'
); hence, a high level is sampled in the ACK time slot (=NACK). Note the interrupt requests right at the end of each byte transmission.