Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freertos xirq example #585

Merged
merged 8 commits into from
Apr 18, 2023
Merged

Conversation

matty0005
Copy link
Contributor

As mentioned #347 (reply in thread) I have created another freertos example for using xirq's.

I have put it in a seperate folder so that it might be less confusing than having several examples in the one folder - I can merge it if needed though.

@stnolting
Copy link
Owner

This looks great! Thank you very much! 👍

Let's merge #586 first and then update this branch.

@stnolting stnolting added the SW Software-related label Apr 15, 2023
@stnolting stnolting marked this pull request as draft April 15, 2023 21:14
stnolting and others added 3 commits April 16, 2023 19:45
@stnolting stnolting marked this pull request as ready for review April 16, 2023 18:14
@stnolting
Copy link
Owner

Seems to be ready to merge 👍

@matty0005
Copy link
Contributor Author

matty0005 commented Apr 16, 2023

I have just fixed up the readme file so that it aligns with the new compile guards.

I also changed the FREERTOS_HOME path for consistency as it mentioned version 10.4.1 but the example output mentions 10.4.4 - might want to do the same for the other freertos example.

@stnolting
Copy link
Owner

I have just fixed up the readme file so that it aligns with the new compile guards.

Great! 👍

I also changed the FREERTOS_HOME path for consistency as it mentioned version 10.4.1 but the example output mentions 10.4.4 - might want to do the same for the other freertos example.

Which definition (where?) of FREERTOS_HOME do you mean?

@matty0005
Copy link
Contributor Author

Which definition (where?) of FREERTOS_HOME do you mean?

Oops, looks like I was looking at a slightly older verision - was fixed in 65820e0

But this was the line I was referring to (this is the updated path).

FREERTOS_HOME ?= /mnt/n/Projects/FreeRTOS

Should be all ready now 👍

@stnolting stnolting merged commit 543e45b into stnolting:main Apr 18, 2023
@stnolting
Copy link
Owner

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SW Software-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants