Updated FIFO NULL assertion fix #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added condition check on fifo_dept_c to ensure we don't get NULL assertions when fifo_depth_c == 1. Reset function already added. Signed-off-by: Mikael Mortensen <119539842+mikaelsky@users.noreply.github.com>
NULL assertion fix in FIFO, was PR stnolting#766
|
Looks good! |
stnolting
approved these changes
Jan 28, 2024
stnolting
added
HW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fifo.vhd has been updated to reflect feedback. Changes has been verified to not cause issues with assertions.
Added a tweak to the write path to make read and write symmetric allowing some flops to potentially be saved for FIFOs of size 1.