[sim] add simulation check to sw makefiles as target 'sim-check' #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
umarcor
added
enhancement
|
That's a really nice solution! 👍 |
stnolting
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #816, this PR moves the cat-grep assert from the simulation shell script to the Makefile of the corresponding software program. In order to do so, target
sim-checkis added, which depends onsim.This approach allows us to have per-program checks. In order to showcase the feature, I added a check to
hello_worldas well.See a successful execution https://github.com/umarcor/neorv32/actions/runs/7977125739 and failures when I changed the strings in the software on purpose: https://github.com/umarcor/neorv32/actions/runs/7977200433.