-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation for symfony/config 4.2+ #388
Conversation
Heavily inspired by symfony/maker-bundle#324
seems like Travis is failing while trying to process tests on PHP 5.3 |
Looks good :) |
Hi @stof what is the process for submitting a PR? Thanks! |
thanks |
Thank you for this fix 👍 any word @stof on tagging a new release? |
@stof hi there! maybe you can release |
it's been 10 months ... do we have to wait for how long ? |
hmm, still no new release? is there some reason for that and if there is how could we help? |
@stof ^^ |
@tarlepp, @inverse take a look here: https://github.com/antishov/StofDoctrineExtensionsBundle/releases ;) it's a good fork. |
@spirit-q2 while forking is a good thing I think it'll be better to ask @stof to be added as a contributor to this repo. This way people don't have to migrate to a new extension and keeps the issues/pull requests centralised. |
@inverse sure thing. I agree with you 100%, but given that the question arose almost year ago (#388 (comment), on Jan 6 2019) I with you a good luck in waiting for response from @stof |
You need to read the issue about the project that is embed in this bundle : doctrine-extensions/DoctrineExtensions#2033 |
@stof if it happens that you will read this message 🤞 then I would like to be an contributor to this repo :) |
Heavily inspired by symfony/maker-bundle#324