Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation for symfony/config 4.2+ #388

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Conversation

bits4breakfast
Copy link
Contributor

Heavily inspired by symfony/maker-bundle#324

@bits4breakfast
Copy link
Contributor Author

seems like Travis is failing while trying to process tests on PHP 5.3

@inverse
Copy link

inverse commented Jan 7, 2019

Looks good :)

@bits4breakfast
Copy link
Contributor Author

Hi @stof what is the process for submitting a PR? Thanks!

@stof stof merged commit ee653c8 into stof:master Jan 8, 2019
@stof
Copy link
Owner

stof commented Jan 8, 2019

thanks

@luispabon
Copy link

Thank you for this fix 👍 any word @stof on tagging a new release?

@spirit-q2
Copy link

@stof hi there! maybe you can release 1.3.1 just with this fix?

@bits4breakfast bits4breakfast deleted the patch-1 branch September 23, 2019 12:24
@cybernet
Copy link

cybernet commented Oct 6, 2019

it's been 10 months ... do we have to wait for how long ?

@tarlepp
Copy link
Contributor

tarlepp commented Dec 1, 2019

hmm, still no new release? is there some reason for that and if there is how could we help?

@inverse
Copy link

inverse commented Dec 1, 2019

@stof ^^

@spirit-q2
Copy link

@tarlepp, @inverse take a look here: https://github.com/antishov/StofDoctrineExtensionsBundle/releases ;) it's a good fork.
thanks @antishov 👍

@inverse
Copy link

inverse commented Dec 2, 2019

@spirit-q2 while forking is a good thing I think it'll be better to ask @stof to be added as a contributor to this repo.

This way people don't have to migrate to a new extension and keeps the issues/pull requests centralised.

@spirit-q2
Copy link

@inverse sure thing. I agree with you 100%, but given that the question arose almost year ago (#388 (comment), on Jan 6 2019) I with you a good luck in waiting for response from @stof :trollface:

@maxhelias
Copy link

You need to read the issue about the project that is embed in this bundle : doctrine-extensions/DoctrineExtensions#2033

@spirit-q2
Copy link

@stof if it happens that you will read this message 🤞 then I would like to be an contributor to this repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants