Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent branch name conflicts in SonarCloud #176

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

dhaiducek
Copy link
Contributor

@dhaiducek dhaiducek commented Jul 8, 2022

When the forked branch has exactly the same name, the rebase fails and then runs a scan with zero changes:

fatal: A branch named 'release-2.4' already exists.

This should fix this collision. Since we set the sonar.pullrequest.branch manually for SonarCloud, I don't think the name difference should affect the scan result, but I'll test that out.

Identified in PR:

Signed-off-by: Dale Haiducek <dhaiduce@redhat.com>
Copy link
Member

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, gurnben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 8, 2022
@openshift-ci openshift-ci bot merged commit e90d32c into stolostron:main Jul 8, 2022
@dhaiducek dhaiducek deleted the dup-name branch July 8, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants