Fix: mapping failed. #660
Merged
Fix: mapping failed. #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
fix-restmapping-fail
branch
from
d2415ef
to
b189b86
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/unhold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Sep 14, 2023
The fix[1] for bug[2] seems to break ManagedClusterView for custom resources (like VolumeReplicationGroup). Ramen works with previous commit[3]. [1] stolostron/multicloud-operators-foundation#660 [2] https://issues.redhat.com/browse/ACM-7479 [3] stolostron/multicloud-operators-foundation@031ee0f Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ACM-7479
Root cause: Start with this PR, the behavior of
NewDynamicRESTMapperchanged.Run this
restMapper.KindFor(&schema.GroupVersionResource{Resource:"deployment"}}), the results:Before it returns a
GroupVersionKind:But now, it returns the error:
The root cause is in controller-runtime
v0.14.6, it reloads by this function: https://github.com/kubernetes-sigs/controller-runtime/blob/cd65cb25d314f40a329a688f4714fe3282589e97/pkg/client/apiutil/dynamicrestmapper.go#L94 which caches all groups and resource from discoveryClient.But after this PR, it reloads by
ServerResourcesForGroupVersionwhich makesversiona required value, and that against our API design ofManagedClusterView.