return resource list instead of string for helm manifest generation #88
Conversation
| chartDir, err := downloadChart(client, s) | ||
| //generateResourceList generates the resource list for given HelmRelease | ||
| func generateResourceList(mgr manager.Manager, s *appv1.HelmRelease) (kube.ResourceList, error) { | ||
| chartDir, err := downloadChart(mgr.GetClient(), s) |
There was a problem hiding this comment.
I think the cache issue is related to this issue,
There was a problem hiding this comment.
mgr.Manager.GetCache().Get(ctx·context.Context,·key·client.ObjectKey,·obj·runtime.Object)
might resolve the cache complain.
The issue to me is, the manager build a cache for configmap, but we still query the k8s directly for the configmap.
Query directly will cause the unstructured object to be created, which somehow confused the cache.
In other words, since we waited for the cache to build up, then we can just use the cache to get object instead of query k8s directly via manager.GetClient()
Signed-off-by: Mike Ng <ming@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ianzhang366, mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mike Ng ming@redhat.com