Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [cherry-pick] fix the cluster name is digital (#621) #125

Merged

Conversation

zhiweiyin318
Copy link

Summary

Related issue(s)

Fixes # https://issues.redhat.com/browse/ACM-14299

Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Copy link

sonarcloud bot commented Oct 14, 2024

@zhiweiyin318
Copy link
Author

/hold
wait from 2.6 z stream open

@zhujian7
Copy link

I think the target branch is backplane-2.6, not konflux/references/backplane-2.6

@zhiweiyin318 zhiweiyin318 changed the base branch from konflux/references/backplane-2.6 to backplane-2.6 October 14, 2024 01:59
@zhiweiyin318
Copy link
Author

/retest

@zhiweiyin318
Copy link
Author

/test e2e

@qiujian16
Copy link
Collaborator

/approve
/lgtm

Copy link

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318
Copy link
Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 5b72e65 into stolostron:backplane-2.6 Oct 18, 2024
13 checks passed
@zhiweiyin318 zhiweiyin318 deleted the cherry-pick-612 branch October 18, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants