Add support for AWS custom VPC

[aswinsuryan]

Add support for AWS custom VPC

[tpantelis]

Unfortunately we can't bump submariner dependencies to 0.19 yet due to the K8s bump to 0.31. The github.com/openshift/library-go needs to bump first, which is pending with openshift/library-go#1771.

# github.com/openshift/library-go/pkg/serviceability
/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20240124134907-4dfbf6bc7b11/pkg/serviceability/panic.go:54:65: cannot use crashOnDelay(delayDuration, delayDurationString) (value of type func(interface{})) as func(context.Context, interface{}) value in argument to append
# k8s.io/component-base/metrics/testutil
/go/pkg/mod/k8s.io/component-base@v0.31.0/metrics/testutil/metrics.go:73:59: undefined: expfmt.NewFormat

[tpantelis]

This error:

# k8s.io/component-base/metrics/testutil
/go/pkg/mod/k8s.io/component-base@v0.31.0/metrics/testutil/metrics.go:73:59: undefined: expfmt.NewFormat

is b/c we're pinning github.com/prometheus/common to v0.47.0 but k8s.io/component-base needs v0.55.0. We should be able to remove the pin now.

[aswinsuryan]

Unfortunately we can't bump submariner dependencies to 0.19 yet due to the K8s bump to 0.31. The github.com/openshift/library-go needs to bump first, which is pending with openshift/library-go#1771.

# github.com/openshift/library-go/pkg/serviceability
/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20240124134907-4dfbf6bc7b11/pkg/serviceability/panic.go:54:65: cannot use crashOnDelay(delayDuration, delayDurationString) (value of type func(interface{})) as func(context.Context, interface{}) value in argument to append
# k8s.io/component-base/metrics/testutil
/go/pkg/mod/k8s.io/component-base@v0.31.0/metrics/testutil/metrics.go:73:59: undefined: expfmt.NewFormat

so we ill have to try get this change in just for 0.16?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tpantelis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarcloud]

Quality Gate failed

Failed conditions
6.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

[openshift-ci]

@aswinsuryan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/golangci-lint	19c2072	link	true	/test golangci-lint
ci/prow/verify	19c2072	link	true	/test verify
ci/prow/build	19c2072	link	true	/test build
ci/prow/unit	19c2072	link	true	/test unit
ci/prow/integration	19c2072	link	true	/test integration
ci/prow/images	19c2072	link	true	/test images
ci/prow/sonarcloud	19c2072	link	true	/test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.