fix(gen): attach the full record schema to the type, including default value #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonalbot
added
automerge
pcavezzan
reviewed
Jul 16, 2024
gen/gen.go
Outdated
Comment on lines
279
to
281
| schemaBytes, _ := schema.MarshalJSON() | ||
| g.typedefs = append(g.typedefs, newType(typeName, schema.Doc(), fields, string(schemaBytes))) |
There was a problem hiding this comment.
Funny that the stringify does not include default value instead of JSON serialization.
There was a problem hiding this comment.
Yeah, the string function returns the canonical form of the schema which does not include the default value sadly.
See: hamba#115 for reference which is the issue that gave birth to the MarshalJSON function
fcote
force-pushed
the
fix/attach-complete-schema-to-types
branch
3 times, most recently
from
591f473
to
f8b7fc7
Compare
fcote
force-pushed
the
fix/attach-complete-schema-to-types
branch
from
f8b7fc7
to
804e007
Compare
fcote
added
the
autoapprove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.