-
-
Notifications
You must be signed in to change notification settings - Fork 141
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(core): rm incorrect boundary check on rough check with between #1344
[summary] 1. change file(tianmu_attr_exeq_rs.cpp) format from dos 2 unix 2. rm incorrect between check, actually the v1 or v2 equal to boundary is illegal and it will cause empty result when condition like `where col = PLUS_INF_64`, `where col = PLUS_INF_DBL`, `where col = MINUS_INF_DBL`: ``` common::RoughSetValue TianmuAttr::RoughCheckBetween(int pack, int64_t v1, int64_ // and then consider negation bool is_float = Type().IsFloat(); auto const &dpn(get_dpn(pack)); - if (!is_float && (v1 == common::PLUS_INF_64 || v2 == common::MINUS_INF_64)) { - res = common::RoughSetValue::RS_NONE; - } else if (is_float && (v1 == *(int64_t *)&common::PLUS_INF_DBL || v2 == *(int64_t *)&common::MINUS_INF_DBL)) { - res = common::RoughSetValue::RS_NONE; - } else if (!is_float && (v1 > dpn.max_i || v2 < dpn.min_i)) { + if (!is_float && (v1 > dpn.max_i || v2 < dpn.min_i)) { ```
- Loading branch information
1 parent
a094688
commit 478e705
Showing
3 changed files
with
1,146 additions
and
1,069 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.