feat(StoneDB 8.0): st_select_lex::set_join is deleted in mysql8.0. (#598

) [summary] 1 take THD::LOCK_query_plan mutex to change the join value;
stoneatom · Sep 28, 2022 · da4752b · da4752b
1 parent 3a8ce12
commit da4752b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 17 deletions.
diff --git a/sql/sql_lex.cc b/sql/sql_lex.cc
@@ -4398,23 +4398,13 @@ void Query_block::include_chain_in_global(Query_block **start) {
   *start = this;
 }
 
-// stonedb8 start TODO: a better way.
-//
-// follows: from MySQL 5.7.36
-//void st_select_lex::set_join(JOIN *join_arg)
-//{
-//  master_unit()->thd->lock_query_plan();
-//  join= join_arg;
-//  master_unit()->thd->unlock_query_plan();
-//}
-//
-void Query_block::set_join(JOIN *join_arg)
+void Query_block::set_join(THD *thd, JOIN *join_arg)
 {
+  thd->lock_query_plan();
   join= join_arg;
+  thd->unlock_query_plan();
 }
 
-// stonedb8 end
-
 /**
    Helper function which handles the "ON conditions" part of
    Query_block::get_optimizable_conditions().

diff --git a/sql/sql_lex.h b/sql/sql_lex.h
@@ -1797,7 +1797,7 @@ class Query_block {
    The function sets the pointer only after acquiring THD::LOCK_query_plan
    mutex. This is needed to avoid races when EXPLAIN FOR CONNECTION is used.
 */
-  void set_join(JOIN *join_arg);
+  void set_join(THD *thd, JOIN *join_arg);
 
   /**
     Does permanent transformations which are local to a query block (which do

diff --git a/storage/tianmu/core/engine_execute.cpp b/storage/tianmu/core/engine_execute.cpp
@@ -361,7 +361,7 @@ int optimize_select(THD *thd, ulong select_options, Query_result *result,
         }       
         if (!(join = new JOIN(thd, select_lex)))
             return true; /* purecov: inspected */
-        select_lex->set_join(join); // stonedb8 TODO
+        select_lex->set_join(thd, join);
 
 	}
     join->best_rowcount = 2;
@@ -564,7 +564,7 @@ int Query_expression::optimize_for_tianmu(THD *thd) {
                     cleanup(thd, 0); // stonedb8
                     return true;
                 }
-                sl->set_join(join);
+                sl->set_join(thd, join);
             }           
             if (is_optimized())
                 sl->join->reset();
@@ -651,7 +651,7 @@ int Query_expression::optimize_after_tianmu(THD *thd)
                 cleanup(thd, 0);  // stonedb8
                 return true;
             }
-            sl->set_join(join);
+            sl->set_join(thd, join);
         }           
         int res = sl->join->optimize(2);
         if (res) {