Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: unsupported DDL in binlog layer should be filtered #1186

Closed
DandreChen opened this issue Jan 3, 2023 · 2 comments
Closed

feature: unsupported DDL in binlog layer should be filtered #1186

DandreChen opened this issue Jan 3, 2023 · 2 comments
Assignees
Labels
A-feature feature with good idea B-DDL DDL related issues B-master-replica master/replica sync, replay B-storage data type, data storage, insert,update,delete, transactions

Comments

@DandreChen
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@DandreChen DandreChen added the A-feature feature with good idea label Jan 3, 2023
@DandreChen DandreChen self-assigned this Jan 3, 2023
@DandreChen DandreChen changed the title feature: unsupported DDL in bingloglayer should report error feature: unsupported DDL in binglog layer should report error Jan 3, 2023
@DandreChen
Copy link
Collaborator Author

Ignore error codes:

/*
      If we get the same error code as expected and it is not a concurrency
      issue, or should be ignored.
    */
    else if ((expected_error == actual_error &&
              !concurrency_error_code(expected_error)) ||
             ignored_error_code(actual_error))
    {
      DBUG_PRINT("info",("error ignored"));
      if (actual_error && ignored_error_code(actual_error))
      {
        if (actual_error == ER_SLAVE_IGNORED_TABLE)
        {
          if (!slave_ignored_err_throttle.log())
            rli->report(INFORMATION_LEVEL, actual_error,
                        "Could not execute %s event. Detailed error: %s;"
                        " Error log throttle is enabled. This error will not be"
                        " displayed for next %lu secs. It will be suppressed",
                        get_type_str(), thd->get_stmt_da()->message_text(),
                        (window_size / 1000000));
        }
        else
          rli->report(INFORMATION_LEVEL, actual_error,
                      "Could not execute %s event. Detailed error: %s;",
                      get_type_str(), thd->get_stmt_da()->message_text());
      }
      clear_all_errors(thd, const_cast<Relay_log_info*>(rli));
      thd->killed= THD::NOT_KILLED;
    }

@DandreChen
Copy link
Collaborator Author

export error codes:

 /*
      Other cases: mostly we expected no error and get one.
    */
    else if (thd->is_slave_error || thd->is_fatal_error)
    {
      if (!is_silent_error(thd))
      {
        rli->report(ERROR_LEVEL, actual_error,
                    "Error '%s' on query. Default database: '%s'. Query: '%s'",
                    (actual_error ?
                     thd->get_stmt_da()->message_text() :
                     "unexpected success or fatal error"),
                    print_slave_db_safe(thd->db().str), query_arg);
      }
      thd->is_slave_error= 1;
    }

@DandreChen DandreChen changed the title feature: unsupported DDL in binglog layer should report error feature: unsupported DDL in binglog layer should be filtered Jan 6, 2023
@wisehead wisehead added this to the stonedb_5.7_v1.0.3 milestone Jan 9, 2023
@wisehead wisehead added B-DDL DDL related issues B-master-replica master/replica sync, replay labels Jan 9, 2023
@DandreChen DandreChen changed the title feature: unsupported DDL in binglog layer should be filtered feature: unsupported DDL in binlog layer should be filtered Jan 10, 2023
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 10, 2023
…toneatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、
foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 10, 2023
…toneatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、
foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 10, 2023
…toneatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、
foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 10, 2023
…neatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、
foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 10, 2023
…neatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、
foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 17, 2023
…neatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 17, 2023
…neatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
Nliver pushed a commit to DandreChen/stonedb that referenced this issue Jan 30, 2023
…neatom#1186)

Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
@hustjieke hustjieke added the B-storage data type, data storage, insert,update,delete, transactions label Jan 30, 2023
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 31, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 31, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 31, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 31, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 31, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Jan 31, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
mergify bot pushed a commit that referenced this issue Jan 31, 2023
Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Feb 2, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
DandreChen added a commit to DandreChen/stonedb that referenced this issue Feb 2, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
mergify bot pushed a commit that referenced this issue Feb 2, 2023
Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
mergify bot pushed a commit that referenced this issue Feb 27, 2023
Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
konghaiya pushed a commit to konghaiya/stonedb that referenced this issue Mar 7, 2023
…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-feature feature with good idea B-DDL DDL related issues B-master-replica master/replica sync, replay B-storage data type, data storage, insert,update,delete, transactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants