Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Header file format standardization #36

Closed
konghaiya opened this issue Jun 19, 2022 · 0 comments · Fixed by #105
Closed

feature: Header file format standardization #36

konghaiya opened this issue Jun 19, 2022 · 0 comments · Fixed by #105
Assignees
Labels
A-feature feature with good idea

Comments

@konghaiya
Copy link
Collaborator

konghaiya commented Jun 19, 2022

Is your feature request related to a problem? Please describe.

#include "core/array_map.h"
#include "core/reactor.h"
#include "fmt/time.h"
#include "log_cli.h"

The header file format is standardized. For the above header files, some contain the directory and some have no path. The included paths should be standardized. Or write the include directory of the header file in cmake. Then, use the method of "path /header.h". The second method is recommended. Its advantage is that you can see its directory.

Describe the solution you'd like

Bad:

#include "core/array_map.h"
#include "core/reactor.h"
#include "fmt/time.h"
#include "log_cli.h"

Valid:

#include "core/array_map.h"
#include "core/reactor.h"
#include "fmt/time.h"
#include "util/log_cli.h"

Describe alternatives you've considered

Additional context

@konghaiya konghaiya added the A-feature feature with good idea label Jun 19, 2022
@konghaiya konghaiya changed the title feature: feature: Header file format standardization Jun 19, 2022
@hustjieke hustjieke added this to the v1.0 milestone Jun 24, 2022
RingsC pushed a commit that referenced this issue Jun 27, 2022
* feat(stonedb): Header file format standardization (#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-feature feature with good idea
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants