Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: add_column test failed. #648

Closed
3 tasks done
hustjieke opened this issue Oct 8, 2022 · 1 comment
Closed
3 tasks done

bug: add_column test failed. #648

hustjieke opened this issue Oct 8, 2022 · 1 comment
Assignees
Labels
A-bug Something isn't working C-stonedb-8.0 associated with stonedb 8.0

Comments

@hustjieke
Copy link
Collaborator

Have you read the Contributing Guidelines on issues?

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Describe the problem

  1. Some warnings happened.
  2. select count(*) result not equal.
--- /github/stonedb/build/install8/mysql-test/suite/tianmu/r/add_column.result	2022-10-08 05:47:07.000000000 +0300
+++ /github/stonedb/build/install8/mysql-test/var/1/log/add_column.reject	2022-10-08 10:17:39.012150523 +0300
@@ -17,6 +17,12 @@
 `c_text` text COMMENT 'text',
 `c_longblob` longblob COMMENT 'longblob'
 ) ENGINE=TIANMU;
+Warnings:
+Warning	1681	Integer display width is deprecated and will be removed in a future release.
+Warning	1681	Integer display width is deprecated and will be removed in a future release.
+Warning	1681	Integer display width is deprecated and will be removed in a future release.
+Warning	1681	Integer display width is deprecated and will be removed in a future release.
+Warning	1681	Integer display width is deprecated and will be removed in a future release.
 load data infile '../../std_data/tianmu/bigdata4load' into table column_type_test fields terminated by '|';
 select count(*) from column_type_test;
 count(*)
@@ -25,11 +31,11 @@
 show create table column_type_test;
 Table	Create Table
 column_type_test	CREATE TABLE `column_type_test` (
-  `c_tinyint` tinyint(4) DEFAULT NULL COMMENT 'tinyint',
-  `c_smallint` smallint(6) DEFAULT NULL COMMENT 'smallint',
-  `c_mediumint` mediumint(9) DEFAULT NULL COMMENT 'mediumint',
-  `c_int` int(11) DEFAULT NULL COMMENT 'int',
-  `c_bigint` bigint(20) DEFAULT NULL COMMENT 'bigint',
+  `c_tinyint` tinyint DEFAULT NULL COMMENT 'tinyint',
+  `c_smallint` smallint DEFAULT NULL COMMENT 'smallint',
+  `c_mediumint` mediumint DEFAULT NULL COMMENT 'mediumint',
+  `c_int` int DEFAULT NULL COMMENT 'int',
+  `c_bigint` bigint DEFAULT NULL COMMENT 'bigint',
   `c_float` float DEFAULT NULL COMMENT 'float',
   `c_double` double DEFAULT NULL COMMENT 'double',
   `c_decimal` decimal(10,5) DEFAULT NULL COMMENT 'decimal',
@@ -42,11 +48,11 @@
   `c_blob` blob COMMENT 'blob',
   `c_text` text COMMENT 'text',
   `c_longblob` longblob COMMENT 'longblob',
-  `ex_column` int(11) DEFAULT NULL
-) ENGINE=TIANMU DEFAULT CHARSET=latin1
+  `ex_column` int DEFAULT NULL
+) ENGINE=TIANMU DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci
 insert into column_type_test(c_tinyint,c_smallint,c_mediumint,c_int,c_bigint,c_float,c_double,c_decimal,c_date,c_datetime,c_timestamp,c_time,c_char,c_varchar,c_text,ex_column)
 values(105,105,105,105,105,5.2,10.88,105.083,'2016-02-25','2016-02-25 10:20:01','2016-02-25 05:20:01','10:20:01','stoneatom','hello','bcdefghijklmn',105);
 select count(*) from column_type_test;
 count(*)
100001

Expected behavior

run all tests passed.

How To Reproduce

  1. cp std_data tianmu from stonedb 5.7 branch.
    cp -r stonedb/mysql-test/std_data/tianmu into stonedb 8.0 branch stonedb/mysql-test/std_data
  2. Setting Running Parameters:mysql-test/include/default_mysqld.cnf
default-storage-engine=tianmu
tianmu_insert_delayed=0
  1. run cmd:
./mysql-test-run.pl --suite=tianmu --nowarnings --force --nocheck-testcases --parallel=10

Environment

  1. ubuntu
  2. 8.0 branch
  3. commit id: 52a721e

Are you interested in submitting a PR to solve the problem?

  • Yes, I will!
@hustjieke hustjieke added the A-bug Something isn't working label Oct 8, 2022
@hustjieke hustjieke self-assigned this Oct 8, 2022
@hustjieke hustjieke added the C-stonedb-8.0 associated with stonedb 8.0 label Oct 8, 2022
@hustjieke hustjieke moved this to In Progress in StoneDB for MySQL 8.0 Oct 8, 2022
@hustjieke hustjieke added this to the stonedb_8.0_v1.0.0 milestone Oct 8, 2022
@hustjieke
Copy link
Collaborator Author

hustjieke added a commit to hustjieke/stonedb-8.0.30-upgrade that referenced this issue Oct 8, 2022
[summary]
1. rm `Deprecate integer display` warnings as --nowarnings does not take effect in 8.0.
For more details, see: https://dev.mysql.com/worklog/task/?id=13127
2. port missing std_data and files in mysql-test from stonedb-5.7-dev.
3. fix uncorrect result of concat test.
hustjieke added a commit to hustjieke/stonedb-8.0.30-upgrade that referenced this issue Oct 8, 2022
[summary]
1. rm `Deprecate integer display` warnings as --nowarnings does not take effect in 8.0.
For more details, see: https://dev.mysql.com/worklog/task/?id=13127
2. port missing std_data and files in mysql-test from stonedb-5.7-dev.
3. fix uncorrect result of concat test.
mergify bot pushed a commit that referenced this issue Oct 9, 2022
[summary]
1. rm `Deprecate integer display` warnings as --nowarnings does not take effect in 8.0.
For more details, see: https://dev.mysql.com/worklog/task/?id=13127
2. port missing std_data and files in mysql-test from stonedb-5.7-dev.
3. fix uncorrect result of concat test.
Repository owner moved this from In Progress to Done in StoneDB for MySQL 8.0 Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bug Something isn't working C-stonedb-8.0 associated with stonedb 8.0
Projects
Development

No branches or pull requests

1 participant