Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): fix bug: The data type was not determined during load data. (#852) #1105

Merged
merged 2 commits into from
Dec 13, 2022
Merged

feat(tianmu): fix bug: The data type was not determined during load data. (#852) #1105

merged 2 commits into from
Dec 13, 2022

Conversation

lujiashun
Copy link

Summary about this PR

Issue Number: close #852
[summary]
function GetValue should not truncate string from delimiter character;
e.g, string "HO,lDAVvCDTthJs3oYHW" enclosed by double-quote, be should stored as a whole;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Dec 9, 2022
@lujiashun lujiashun marked this pull request as draft December 12, 2022 01:33
feat(tianmu): fix bug: The data type was not determined during load d…
54b3bee 
…ata. (stoneatom#852)

[summary]
function GetValue should not truncate string from delimiter character;
e.g,  string "HO,lDAVvCDTthJs3oYHW" enclosed by double-quote, be should stored as a whole;
@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited
Loading

Codecov Report

Base: 33.92% // Head: 33.92% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (54b3bee) compared to base (40f2e1f).
Patch has no changes to coverable lines.

❗ Current head 54b3bee differs from pull request most recent head 29b7f8b. Consider uploading reports for the commit 29b7f8b to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1105      +/-   ##
===================================================
- Coverage            33.92%   33.92%   -0.01%     
===================================================
  Files                 1807     1807              
  Lines               395062   395058       -4     
===================================================
- Hits                134036   134030       -6     
- Misses              261026   261028       +2
Impacted Files Coverage Δ
storage/tianmu/loader/parsing_strategy.cpp 60.34% <ø> (+4.33%) ⬆️
mysys/mf_iocache.c 47.90% <0.00%> (-2.72%) ⬇️
storage/myisam/mi_dynrec.c 51.17% <0.00%> (-1.24%) ⬇️
storage/innobase/include/ib0mutex.h 63.05% <0.00%> (-1.12%) ⬇️
storage/innobase/fut/fut0lst.cc 68.42% <0.00%> (-1.06%) ⬇️
storage/innobase/fil/fil0fil.cc 47.87% <0.00%> (-0.25%) ⬇️
sql/sql_yacc.yy 41.99% <0.00%> (-0.16%) ⬇️
storage/tianmu/handler/ha_tianmu.cpp 51.88% <0.00%> (-0.15%) ⬇️
sql/rpl_slave.cc 41.37% <0.00%> (+0.03%) ⬆️
storage/innobase/include/ut0new.h 45.22% <0.00%> (+0.06%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lujiashun lujiashun marked this pull request as ready for review December 12, 2022 02:01
@lujiashun lujiashun self-assigned this Dec 12, 2022
RingsC
RingsC approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hustjieke
hustjieke approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 3398895 into stoneatom:stonedb-5.7-dev Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

@wisehead wisehead Awaiting requested review from wisehead

@duanfuxiang0 duanfuxiang0 Awaiting requested review from duanfuxiang0

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@lujiashun lujiashun

Labels
PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: The data type was not determined during load data
3 participants
@lujiashun @RingsC @hustjieke